Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Column Pruning and support where case: like and not like, is not null #93

Merged
merged 7 commits into from
Nov 11, 2023
Merged

Refactor Column Pruning and support where case: like and not like, is not null #93

merged 7 commits into from
Nov 11, 2023

Conversation

KKould
Copy link
Member

@KKould KKould commented Nov 6, 2023 •
edited
Loading

What is changed and how it works?

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould KKould requested review from lewiszlw and loloxwg and removed request for lewiszlw November 6, 2023 14:47
@KKould KKould self-assigned this Nov 6, 2023
@KKould KKould added enhancement New feature or request invalid This doesn't seem right labels Nov 6, 2023
@lewiszlw
Copy link
Member

lewiszlw commented Nov 7, 2023

This pr contains like/null expr, ColumnCatalog refactoring, constant calculation, column pruning, etc, not friendly to reviewer. You could split pr into smaller pieces next time.

@KKould KKould merged commit 09c1042 into KipData:main Nov 11, 2023
3 checks passed
KKould added a commit to KKould/KipSQL that referenced this pull request Nov 11, 2023
@KKould
Refactor Column Pruning and support where case: like and not like…
95a20c4 
…, `is not null` (KipData#93)

* refactor(column_pruning): reconstruct column clipping using Column detection under self-direction 1

* feat(simplify): add `constant_calculation` compute constant calculations ahead of time to avoid double calculations

* feat: support like operator

* feat: support is not null operator

* ci: nightly version

* config: nightly version update

* ci: config toolchain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loloxwg loloxwg Awaiting requested review from loloxwg

@lewiszlw lewiszlw Awaiting requested review from lewiszlw

Assignees

@KKould KKould

Labels
enhancement New feature or request invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KKould @lewiszlw